Fix problems updating status on WSAs #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octonautcal
reviewed
Nov 2, 2025
| case *agentoctopuscomv1beta1.WorkloadServiceAccountStatus: | ||
| s.Conditions = updateCondition(s.Conditions, ConditionTypeReady, | ||
| "False", ReasonReconcileFailed, err.Error()) | ||
| case *agentoctopuscomv1beta1.ClusterWorkloadServiceAccountStatus: |
There was a problem hiding this comment.
can this be simplified to:
switch any(status).(type) {
case *agentoctopuscomv1beta1.WorkloadServiceAccountStatus,
*agentoctopuscomv1beta1.ClusterWorkloadServiceAccountStatus:
status.Conditions = updateCondition(status.Conditions, ConditionTypeReady,
"False", ReasonReconcileFailed, err.Error())
}
?
Maybe this is code style preference though for readability
There was a problem hiding this comment.
When I tried to do this, Go couldn't be certain on the type that I was asserting, so Conditions didn't exist 😞
octonautcal
approved these changes
Nov 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating a cWSA or WSA, we would get failures due to transition time being missing, as well as problems with conflicts when trying to apply. This PR fixes this by adding retries on conflicts, and by setting the
LastTransitionTimeproperly.